One last thing to try to solve the knocking sound.
I had exactly the same thing, knocking sound on one side and not the other with after market suspension mods fitted by someone else. The car made a noise going over bumps or into potholes mostly at ordinary speeds, worse slower.
Turned out that on one side they fitted the bump stop up side down so that the plastic ring end of the bump stop was at the top going into the mount. It looks like you've taken the whole thing to bits so i guess you would have seen this, but as in my 4 visits to get this put right people always put things on the way they came off so you never know. Good luck.
